> On Dec. 29, 2014, 10:37 a.m., Rajat Khandelwal wrote: > > lens-cube/src/main/java/org/apache/lens/cube/metadata/ExprColumn.java, line > > 31 > > <https://reviews.apache.org/r/29451/diff/1/?file=802160#file802160line31> > > > > Encoding seems safe here. Even control characters might come in the > > expression. The drawback is that we wouldn't be able to decode the > > expression by looking at the output of `describe cube`
describe cube should be fine, as we would decode and return. Describe on native hive tables will be problem, but that should be fine. - Amareshwari ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29451/#review66242 ----------------------------------------------------------- On Dec. 29, 2014, 8:31 a.m., Jaideep dhok wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29451/ > ----------------------------------------------------------- > > (Updated Dec. 29, 2014, 8:31 a.m.) > > > Review request for lens. > > > Bugs: LENS-175 > https://issues.apache.org/jira/browse/LENS-175 > > > Repository: lens > > > Description > ------- > > Changes in ExprColumn and test changes to validate multiple expressions. No > changes required in CubeMetastoreClient > > > Diffs > ----- > > lens-cube/src/main/java/org/apache/lens/cube/metadata/ExprColumn.java > 352fef9 > > lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java > 5889506 > > Diff: https://reviews.apache.org/r/29451/diff/ > > > Testing > ------- > > Added new tests for creating and altering multiple expressions. > No impact on existing lens-cube tests. I'll update JIRA with complete test > report. > > > Thanks, > > Jaideep dhok > >
