----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29035/#review68698 -----------------------------------------------------------
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java <https://reviews.apache.org/r/29035/#comment113078> In run() method, I see LensException can be thrown from following lines: LensResultSet set = getResultset(finished.getCtx().getQueryHandle()); LensResultSetMetadata metadata = set.getMetadata(); int rows = set.size(); I see in the code all three occurances are resulting in dropping. Should we add try catch around result set fetching and increment counter? Or Persist without resultset details - not to loose it fully? Or move the same under retries? lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java <https://reviews.apache.org/r/29035/#comment113079> This catch all exception is to make purger thread alive with any of system runtime exceptions. We should still increment purger error for this and not dropped queries. lens-server/src/main/resources/lensserver-default.xml <https://reviews.apache.org/r/29035/#comment113080> Thanks for the cleanup :) lens-server/src/main/resources/lensserver-default.xml <https://reviews.apache.org/r/29035/#comment113081> How many retries will happen with 5hours with current calculation put in? Can we update doc with this hint and, may be give explanation of how that is calculated also. - Amareshwari Sriramadasu On Jan. 19, 2015, 2:36 p.m., Rajat Khandelwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29035/ > ----------------------------------------------------------- > > (Updated Jan. 19, 2015, 2:36 p.m.) > > > Review request for lens. > > > Bugs: LENS-120 > https://issues.apache.org/jira/browse/LENS-120 > > > Repository: lens > > > Description > ------- > > QueryPurger Should retry with a timeout if db connection is not working. Also > There should be a limit to number of timeouts > > Raised https://issues.apache.org/jira/browse/LENS-207 for secondary > persistence. > > > Diffs > ----- > > > lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java > 0ae539e > > lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryDroppedInPurge.java > PRE-CREATION > lens-server/src/main/java/org/apache/lens/server/query/LensServerDAO.java > 4dc8daf > > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java > 9521136 > lens-server/src/main/resources/lensserver-default.xml 5d99b87 > lens-server/src/test/java/org/apache/lens/server/query/TestLensDAO.java > 7ff1aa4 > src/site/apt/admin/config.apt 9bd18ae > > Diff: https://reviews.apache.org/r/29035/diff/ > > > Testing > ------- > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.562s] > [INFO] Lens .............................................. SUCCESS [1.972s] > [INFO] Lens API .......................................... SUCCESS [6.124s] > [INFO] Lens API for server and extensions ................ SUCCESS [6.319s] > [INFO] Lens Cube ......................................... SUCCESS [7:13.138s] > [INFO] Lens DB storage ................................... SUCCESS [12.688s] > [INFO] Lens Query Library ................................ SUCCESS [6.182s] > [INFO] Lens Hive Driver .................................. SUCCESS [3:15.119s] > [INFO] Lens Driver for Cloudera Impala ................... SUCCESS [3.575s] > [INFO] Lens Driver for JDBC .............................. SUCCESS [29.247s] > [INFO] Lens Server ....................................... SUCCESS [5:04.414s] > [INFO] Lens client ....................................... SUCCESS [25.776s] > [INFO] Lens CLI .......................................... SUCCESS [2:03.041s] > [INFO] Lens Examples ..................................... SUCCESS [0.938s] > [INFO] Lens Distribution ................................. SUCCESS [4.746s] > [INFO] Lens Client Distribution .......................... SUCCESS [7.435s] > [INFO] Lens ML Lib ....................................... SUCCESS [47.815s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 20:12.199s > [INFO] Finished at: Mon Jan 19 14:31:39 UTC 2015 > [INFO] Final Memory: 101M/1439M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Rajat Khandelwal > >
