> On Jan. 11, 2015, 6:38 a.m., Amareshwari Sriramadasu wrote: > > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java, > > line 255 > > <https://reviews.apache.org/r/29035/diff/3/?file=814142#file814142line255> > > > > Move the variable to QueryPurger?
No. It's used in `FinishedQuery`. And logically it should be a `static final` property of that class but inner classes can't have static variables, so. And there's no point re-initializing it for each instance of `FinishedQuery` Class. > On Jan. 11, 2015, 6:38 a.m., Amareshwari Sriramadasu wrote: > > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java, > > line 816 > > <https://reviews.apache.org/r/29035/diff/3/?file=814142#file814142line816> > > > > One thing that I still have concern is - if the cause is because of DB > > issue, we are dropping the queries after timeout and raise event for each > > query Not raising event for each query, for each query exponential backoff runs and only when that's done the event is raised. So if we have alerting on the number of such events, the issue can be investigated and fixed in time. Some queries which were in exponential backoff stage will be persisted as soon as it's fixed. - Rajat ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29035/#review67608 ----------------------------------------------------------- On Jan. 9, 2015, 7:35 a.m., Rajat Khandelwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29035/ > ----------------------------------------------------------- > > (Updated Jan. 9, 2015, 7:35 a.m.) > > > Review request for lens. > > > Bugs: LENS-120 > https://issues.apache.org/jira/browse/LENS-120 > > > Repository: lens > > > Description > ------- > > QueryPurger Should retry with a timeout if db connection is not working. Also > There should be a limit to number of timeouts > > > Diffs > ----- > > > lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java > 0ae539e > > lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryPurgeFailed.java > PRE-CREATION > > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java > 9521136 > > Diff: https://reviews.apache.org/r/29035/diff/ > > > Testing > ------- > > > Thanks, > > Rajat Khandelwal > >
