----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29035/#review68024 -----------------------------------------------------------
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryPurgeFailed.java <https://reviews.apache.org/r/29035/#comment112172> Lets call it QueryPersistFailed and also document the query is no longer available in memory or DB lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java <https://reviews.apache.org/r/29035/#comment112175> I would say dropping should happen only for the insertion failing because it is duplicate insertion : we should never be doing duplicate insertions - we can fix code to ensure this and avoid dropping altogether. Overall, i feel lets not drop queries anytime. We can fix follow up task to add primary and secondary persistence for finished queries. lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java <https://reviews.apache.org/r/29035/#comment112173> I dont think this is dropped queries counter. We are incrementing for any error on purger - Amareshwari Sriramadasu On Jan. 12, 2015, 9:24 a.m., Rajat Khandelwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29035/ > ----------------------------------------------------------- > > (Updated Jan. 12, 2015, 9:24 a.m.) > > > Review request for lens. > > > Bugs: LENS-120 > https://issues.apache.org/jira/browse/LENS-120 > > > Repository: lens > > > Description > ------- > > QueryPurger Should retry with a timeout if db connection is not working. Also > There should be a limit to number of timeouts > > > Diffs > ----- > > > lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java > 0ae539e > > lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryPurgeFailed.java > PRE-CREATION > > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java > 9521136 > lens-server/src/main/resources/lensserver-default.xml 5d99b87 > src/site/apt/admin/config.apt 9bd18ae > > Diff: https://reviews.apache.org/r/29035/diff/ > > > Testing > ------- > > > Thanks, > > Rajat Khandelwal > >
