----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29881/#review68893 -----------------------------------------------------------
lens-cube/src/main/java/org/apache/lens/cube/parse/GroupbyResolver.java <https://reviews.apache.org/r/29881/#comment113425> Do we need to iterate over child nodes? Since node passed here is single expression AST, above if check of hasTableOrColumn and returning true or false accordingly should work. Also, the boolean isConstant should not be required in the method param lens-cube/src/main/java/org/apache/lens/cube/parse/GroupbyResolver.java <https://reviews.apache.org/r/29881/#comment113424> call it hasTableOrColumn ? - Amareshwari Sriramadasu On Jan. 21, 2015, 10:55 a.m., Sushil Mohanty wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29881/ > ----------------------------------------------------------- > > (Updated Jan. 21, 2015, 10:55 a.m.) > > > Review request for lens and Amareshwari Sriramadasu. > > > Bugs: LENS-131 > https://issues.apache.org/jira/browse/LENS-131 > > > Repository: lens > > > Description > ------- > > When constants get projected the queries by default they were being added to > group by. Such queries fail with No Such Column error. > > > Diffs > ----- > > lens-cube/src/main/java/org/apache/lens/cube/parse/GroupbyResolver.java > 2531c49 > lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java > cb70b66 > > Diff: https://reviews.apache.org/r/29881/diff/ > > > Testing > ------- > > Tested with queries with different types of constants projected and rewriter > skipping them in group by. Added unit test for the same. > > > Thanks, > > Sushil Mohanty > >
