-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29881/
-----------------------------------------------------------
(Updated Jan. 21, 2015, 10:55 a.m.)
Review request for lens and Amareshwari Sriramadasu.
Changes
-------
Added a method to check column or constants and add them to group by
accordingly. Addressed the new review comments.
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [5.255s]
[INFO] Lens .............................................. SUCCESS [0.403s]
[INFO] Lens API .......................................... SUCCESS [9.272s]
[INFO] Lens API for server and extensions ................ SUCCESS [9.158s]
[INFO] Lens Cube ......................................... SUCCESS [10:22.629s]
[INFO] Lens DB storage ................................... SUCCESS [21.294s]
[INFO] Lens Query Library ................................ SUCCESS [7.524s]
[INFO] Lens Hive Driver .................................. SUCCESS [3:55.945s]
[INFO] Lens Driver for Cloudera Impala ................... SUCCESS [6.326s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [35.656s]
[INFO] Lens Server ....................................... SUCCESS [9:23.056s]
[INFO] Lens client ....................................... SUCCESS [36.529s]
[INFO] Lens CLI .......................................... SUCCESS [2:36.283s]
[INFO] Lens Examples ..................................... SUCCESS [2.232s]
[INFO] Lens Distribution ................................. SUCCESS [2.076s]
[INFO] Lens Client Distribution .......................... SUCCESS [2.893s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:22.679s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 30:00.035s
[INFO] Finished at: Wed Jan 21 16:05:43 GMT+05:30 2015
[INFO] Final Memory: 78M/1078M
[INFO] ------------------------------------------------------------------------
Bugs: LENS-131
https://issues.apache.org/jira/browse/LENS-131
Repository: lens
Description
-------
When constants get projected the queries by default they were being added to
group by. Such queries fail with No Such Column error.
Diffs (updated)
-----
lens-cube/src/main/java/org/apache/lens/cube/parse/GroupbyResolver.java
2531c49
lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java
cb70b66
Diff: https://reviews.apache.org/r/29881/diff/
Testing
-------
Tested with queries with different types of constants projected and rewriter
skipping them in group by. Added unit test for the same.
Thanks,
Sushil Mohanty
