----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30413/#review70209 -----------------------------------------------------------
lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java <https://reviews.apache.org/r/30413/#comment115282> Should we through this exception here out? I'm thinking server should restart without any issues if it is not able to restore previous state. Thoughts? lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java <https://reviews.apache.org/r/30413/#comment115287> Doing restartLensServer() as part of unit test would break other tests. We might have to move this TestServerRestart which is in different group. lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java <https://reviews.apache.org/r/30413/#comment115285> Is this method not available in test already? lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java <https://reviews.apache.org/r/30413/#comment115286> Is this method not available in test already? - Amareshwari Sriramadasu On Jan. 29, 2015, 1:34 p.m., Himanshu Gahlaut wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30413/ > ----------------------------------------------------------- > > (Updated Jan. 29, 2015, 1:34 p.m.) > > > Review request for lens. > > > Repository: lens > > > Description > ------- > > Handled exception generated while adding relocated resources during session > restore. > > > Diffs > ----- > > > lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java > 7641232 > > lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java > 109b36d > lens-server/src/test/resources/restart-on-resource-move-test.jar > PRE-CREATION > > Diff: https://reviews.apache.org/r/30413/diff/ > > > Testing > ------- > > Unit Test case written for issue at hand. Will publish result of running all > unit test cases shortly. > > > Thanks, > > Himanshu Gahlaut > >
