----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30413/#review70323 -----------------------------------------------------------
lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java <https://reviews.apache.org/r/30413/#comment115431> Add assert in try block after the call marking success. And add a catch block which has `Assert.fail()`. - Rajat Khandelwal On Jan. 29, 2015, 5:23 p.m., Himanshu Gahlaut wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30413/ > ----------------------------------------------------------- > > (Updated Jan. 29, 2015, 5:23 p.m.) > > > Review request for lens. > > > Repository: lens > > > Description > ------- > > Handled exception generated while adding relocated resources during session > restore. > > > Diffs > ----- > > > lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java > 7641232 > > lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java > 109b36d > lens-server/src/test/resources/restart-on-resource-move-test.jar > PRE-CREATION > > Diff: https://reviews.apache.org/r/30413/diff/ > > > Testing > ------- > > Unit Test case written for issue at hand. Will publish result of running all > unit test cases shortly. > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules ............................. SUCCESS [12.027s] > [INFO] Lens .............................................. SUCCESS [6.598s] > [INFO] Lens API .......................................... SUCCESS [9.964s] > [INFO] Lens API for server and extensions ................ SUCCESS [9.090s] > [INFO] Lens Cube ......................................... SUCCESS [8:00.339s] > [INFO] Lens DB storage ................................... SUCCESS [41.224s] > [INFO] Lens Query Library ................................ SUCCESS [22.335s] > [INFO] Lens Hive Driver .................................. SUCCESS > [13:40.708s] > [INFO] Lens Driver for Cloudera Impala ................... SUCCESS [5.775s] > [INFO] Lens Driver for JDBC .............................. SUCCESS [45.552s] > [INFO] Lens Server ....................................... SUCCESS > [16:57.945s] > [INFO] Lens client ....................................... SUCCESS [1:01.377s] > [INFO] Lens CLI .......................................... SUCCESS [5:08.882s] > [INFO] Lens Examples ..................................... SUCCESS [1.449s] > [INFO] Lens Distribution ................................. SUCCESS [5.741s] > [INFO] Lens Client Distribution .......................... SUCCESS [7.128s] > [INFO] Lens ML Lib ....................................... SUCCESS [2:16.720s] > [INFO] Lens Regression ................................... SUCCESS [0.451s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 49:54.335s > [INFO] Finished at: Thu Jan 29 21:07:30 IST 2015 > [INFO] Final Memory: 98M/295M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Himanshu Gahlaut > >
