> On Jan. 29, 2015, 3:39 p.m., Amareshwari Sriramadasu wrote: > > lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java, > > line 297 > > <https://reviews.apache.org/r/30413/diff/1/?file=840119#file840119line297> > > > > Should we through this exception here out? I'm thinking server should > > restart without any issues if it is not able to restore previous state. > > > > Thoughts?
It would be better if we inform the user/admin about the server's restore failure status instead of silently restarting the server without any issues. Can we provide an option to user/admin to restart server with partial state or not? So that user/admin can take decision based on their importance of resource. - Raju ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30413/#review70209 ----------------------------------------------------------- On Jan. 29, 2015, 1:34 p.m., Himanshu Gahlaut wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30413/ > ----------------------------------------------------------- > > (Updated Jan. 29, 2015, 1:34 p.m.) > > > Review request for lens. > > > Repository: lens > > > Description > ------- > > Handled exception generated while adding relocated resources during session > restore. > > > Diffs > ----- > > > lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java > 7641232 > > lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java > 109b36d > lens-server/src/test/resources/restart-on-resource-move-test.jar > PRE-CREATION > > Diff: https://reviews.apache.org/r/30413/diff/ > > > Testing > ------- > > Unit Test case written for issue at hand. Will publish result of running all > unit test cases shortly. > > > Thanks, > > Himanshu Gahlaut > >
