----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31116/#review72721 -----------------------------------------------------------
README.md <https://reviews.apache.org/r/31116/#comment118776> Typo bin-dist-files/README <https://reviews.apache.org/r/31116/#comment118777> I know we are also creating a deb file. Do we intend to make it available as a conveninent binary ? If so, we should have notes on how to setup using deb, else you can ignore. In general there needs to documentation on how deb can be used for installation, but that can be taken up in an independent jira and not a blocker for release. src/site/apt/releases/release-history.apt <https://reviews.apache.org/r/31116/#comment118778> Why is this in release history and not in README ? Should we state why it is excluded as well ? - Srikanth Sundarrajan On Feb. 17, 2015, 3:33 p.m., Amareshwari Sriramadasu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31116/ > ----------------------------------------------------------- > > (Updated Feb. 17, 2015, 3:33 p.m.) > > > Review request for lens, Chris Douglas and Srikanth Sundarrajan. > > > Bugs: LENS-311 > https://issues.apache.org/jira/browse/LENS-311 > > > Repository: lens > > > Description > ------- > > Changes include : > - Change source release artifact name to include apache-lens. Changed > lens-parent to apache-lens. > - Add exclusion for org.acplt:oncrpc in apache-release profile > - Add LICENSE and NOTICE in war packaging > - Update README.md for source distribution > - Update bin-dist-files/README for binary distribution > > Have some questions : > - LICENSE and NOTICE in lens-server.war looks the following. Is this > acceptable? > $ ls webapp/lens-server/ > META-INF/ WEB-INF/ static/ > > $ ls webapp/lens-server/META-INF/ > MANIFEST.MF maven/ > > $ ls webapp/lens-server/WEB-INF/ > classes/ lib/ log4j.properties web.xml > > $ ls webapp/lens-server/WEB-INF/classes/ > META-INF/ lens-build-info.properties > lensserver-default.xml lenssession-default.xml org/ > > $ ls webapp/lens-server/WEB-INF/classes/META-INF/ > DEPENDENCIES LICENSE NOTICE > > - Is it ok to have README file README.md for source distribution? > - bin-dist-files folder is included in src distribution. Is it acceptable? > > > Diffs > ----- > > README.md 07a3249 > bin-dist-files/README 3e74fb9 > lens-api/pom.xml b955c1a > lens-cli/pom.xml 26adc54 > lens-client/pom.xml e56df03 > lens-cube/pom.xml 274d1ea > lens-dist/pom.xml ddebf16 > lens-driver-hive/pom.xml be0c1b7 > lens-driver-jdbc/pom.xml daab50d > lens-examples/pom.xml 2163785 > lens-ml-lib/pom.xml 3cdca92 > lens-query-lib/pom.xml 95d9d93 > lens-regression/pom.xml d506eaa > lens-server-api/pom.xml f490dee > lens-server/pom.xml 0986ab9 > lens-storage-db/pom.xml fb35e12 > pom.xml 38d1693 > src/site/apt/lenshome/install-and-run.apt 6031cf9 > src/site/apt/releases/release-history.apt f5f6139 > > Diff: https://reviews.apache.org/r/31116/diff/ > > > Testing > ------- > > Verified packaging is fine by untarring the distribution. Will do some more > testing and update here. > > > Thanks, > > Amareshwari Sriramadasu > >
