-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31116/
-----------------------------------------------------------
(Updated Feb. 18, 2015, 8:35 a.m.)
Review request for lens, Chris Douglas and Srikanth Sundarrajan.
Changes
-------
Fixed debian issues.
Named untarred binary distribution to contain -bin in the name. Otherwise both
source and binary were getting unzipped/untarred into same directory.
Bugs: LENS-311
https://issues.apache.org/jira/browse/LENS-311
Repository: lens
Description
-------
Changes include :
- Change source release artifact name to include apache-lens. Changed
lens-parent to apache-lens.
- Add exclusion for org.acplt:oncrpc in apache-release profile
- Add LICENSE and NOTICE in war packaging
- Update README.md for source distribution
- Update bin-dist-files/README for binary distribution
Have some questions :
- LICENSE and NOTICE in lens-server.war looks the following. Is this acceptable?
$ ls webapp/lens-server/
META-INF/ WEB-INF/ static/
$ ls webapp/lens-server/META-INF/
MANIFEST.MF maven/
$ ls webapp/lens-server/WEB-INF/
classes/ lib/ log4j.properties web.xml
$ ls webapp/lens-server/WEB-INF/classes/
META-INF/ lens-build-info.properties lensserver-default.xml
lenssession-default.xml org/
$ ls webapp/lens-server/WEB-INF/classes/META-INF/
DEPENDENCIES LICENSE NOTICE
- Is it ok to have README file README.md for source distribution?
- bin-dist-files folder is included in src distribution. Is it acceptable?
Diffs (updated)
-----
README.md 07a3249
bin-dist-files/README 3e74fb9
lens-api/pom.xml b955c1a
lens-cli/pom.xml 26adc54
lens-client/pom.xml e56df03
lens-cube/pom.xml 274d1ea
lens-dist/pom.xml ddebf16
lens-dist/src/deb/control/server-control/postinst 0cd9d57
lens-dist/src/main/assembly/bin-dist.xml 4ec2d55
lens-driver-hive/pom.xml be0c1b7
lens-driver-jdbc/pom.xml daab50d
lens-examples/pom.xml 2163785
lens-ml-lib/pom.xml 3cdca92
lens-query-lib/pom.xml 95d9d93
lens-regression/pom.xml d506eaa
lens-server-api/pom.xml f490dee
lens-server/pom.xml 0986ab9
lens-storage-db/pom.xml fb35e12
pom.xml 38d1693
src/site/apt/developer/contribute.apt 91e7b81
src/site/apt/lenshome/install-and-run.apt 6031cf9
src/site/apt/releases/release-history.apt f5f6139
tools/scripts/lens-cli 66106c1
Diff: https://reviews.apache.org/r/31116/diff/
Testing (updated)
-------
Verified packaging is fine by untarring the distribution.
Build from source tarball succeeds :
unzip apache-lens-2.1.0-incubating-SNAPSHOT-source-release.zip
mvn clean package -DskipTests.
Running all tests. Will update once done
Ran examples from binary distribution.
Installed debians, started server from deb installation and verified client
through cli.
Thanks,
Amareshwari Sriramadasu
