> On March 23, 2015, 9:23 a.m., Himanshu Gahlaut wrote:
> > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java,
> > line 36
> > <https://reviews.apache.org/r/32388/diff/1/?file=902605#file902605line36>
> >
> > will @Slf4j work in place of @CommonsLog ?
>
> Rajat Khandelwal wrote:
> Everywhere we're using commons log. Don't know whether slf4j will work or
> not.
It should work if below dependencies are present in pom.xml and
log4j.properties is present in classpath. I guess I already used it in test
cases of lens-cube. Refer annotaion on CubeTestSetup.class.
<dependency>
<groupId>org.projectlombok</groupId>
<artifactId>lombok</artifactId>
</dependency>
<dependency>
<groupId>org.slf4j</groupId>
<artifactId>slf4j-api</artifactId>
</dependency>
<dependency>
<groupId>org.slf4j</groupId>
<artifactId>slf4j-log4j12</artifactId>
</dependency>
<dependency>
<groupId>log4j</groupId>
<artifactId>log4j</artifactId>
</dependency>
Its better to use @Slf4j in new code so that parametrized logging can be
utilized and we can slowly move towards using logback instead of log4j for
better logging performance and better features.
- Himanshu
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32388/#review77383
-----------------------------------------------------------
On March 23, 2015, 7:26 a.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32388/
> -----------------------------------------------------------
>
> (Updated March 23, 2015, 7:26 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-412
> https://issues.apache.org/jira/browse/LENS-412
>
>
> Repository: lens
>
>
> Description
> -------
>
> some moving around in error codes.
>
>
> Diffs
> -----
>
>
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java
> bfeff4f7443a3e8d0adcf04dc9a5a440e5a3fc24
>
> lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java
> c29d88f1fe32c62947af6ca44179299d446c638c
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java
> 42782297118dbff231cc2a02de8813f58162b705
>
> Diff: https://reviews.apache.org/r/32388/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
