> On March 23, 2015, 1:28 p.m., Amareshwari Sriramadasu wrote: > > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java, > > line 99 > > <https://reviews.apache.org/r/32388/diff/1/?file=902605#file902605line99> > > > > We need to have this back. May be the storage cause should get bubbled > > up. > > Rajat Khandelwal wrote: > We can keep both.
Not adding this back. brief error can have it when it's the most severe of all the errors. - Rajat ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32388/#review77380 ----------------------------------------------------------- On March 24, 2015, 12:42 p.m., Rajat Khandelwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32388/ > ----------------------------------------------------------- > > (Updated March 24, 2015, 12:42 p.m.) > > > Review request for lens. > > > Bugs: LENS-412 > https://issues.apache.org/jira/browse/LENS-412 > > > Repository: lens > > > Description > ------- > > some moving around in error codes. > > > Diffs > ----- > > > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java > bfeff4f7443a3e8d0adcf04dc9a5a440e5a3fc24 > lens-cube/src/main/java/org/apache/lens/cube/parse/PruneCauses.java > ae9e0136ba521fbcc7fc139bc79dbb1df7c7f6e5 > > lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java > c29d88f1fe32c62947af6ca44179299d446c638c > lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java > 42782297118dbff231cc2a02de8813f58162b705 > > lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java > c9972e23419a00fb5729b854b8feea9b44b125a3 > > Diff: https://reviews.apache.org/r/32388/diff/ > > > Testing > ------- > > > Thanks, > > Rajat Khandelwal > >
