> On March 24, 2015, 2:16 p.m., Amareshwari Sriramadasu wrote: > > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java, > > line 74 > > <https://reviews.apache.org/r/32388/diff/3/?file=903845#file903845line74> > > > > Why is the order changed? > > > > No fact update period should take more precedence than unsupported > > storage. I think that would be broken. > > > > Or this might also be moved to storage causes.
no fact update period is checked before the storage level check. So I think if one fact was skipped because of no suitable update periods, and another was skipped because of storage table level causes, then the latter error is the one that should get priority. > On March 24, 2015, 2:16 p.m., Amareshwari Sriramadasu wrote: > > lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java, > > line 540 > > <https://reviews.apache.org/r/32388/diff/3/?file=903847#file903847line540> > > > > This is not adding all missing parts. > > SkipStorageCause.missingPartitions is doing simple set on the ArrayList - > > would always set only one missing partition. Depends on `CubeQueryConfUtil.ADD_NON_EXISTING_PARTITIONS`. If true, all missing parts will be added. If not, one missing part of each of the storage tables will be displayed in the final error. - Rajat ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32388/#review77539 ----------------------------------------------------------- On March 24, 2015, 12:54 p.m., Rajat Khandelwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32388/ > ----------------------------------------------------------- > > (Updated March 24, 2015, 12:54 p.m.) > > > Review request for lens. > > > Bugs: LENS-412 > https://issues.apache.org/jira/browse/LENS-412 > > > Repository: lens > > > Description > ------- > > some moving around in error codes. > > > Diffs > ----- > > > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java > bfeff4f7443a3e8d0adcf04dc9a5a440e5a3fc24 > lens-cube/src/main/java/org/apache/lens/cube/parse/PruneCauses.java > ae9e0136ba521fbcc7fc139bc79dbb1df7c7f6e5 > > lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java > c29d88f1fe32c62947af6ca44179299d446c638c > lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java > 42782297118dbff231cc2a02de8813f58162b705 > > lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java > c9972e23419a00fb5729b854b8feea9b44b125a3 > > Diff: https://reviews.apache.org/r/32388/diff/ > > > Testing > ------- > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.340s] > [INFO] Lens .............................................. SUCCESS [1.828s] > [INFO] Lens API .......................................... SUCCESS [5.302s] > [INFO] Lens API for server and extensions ................ SUCCESS [6.013s] > [INFO] Lens Cube ......................................... SUCCESS [1:59.809s] > [INFO] Lens DB storage ................................... SUCCESS [10.082s] > [INFO] Lens Query Library ................................ SUCCESS [4.889s] > [INFO] Lens Hive Driver .................................. SUCCESS [2:36.279s] > [INFO] Lens Driver for JDBC .............................. SUCCESS [17.846s] > [INFO] Lens Server ....................................... SUCCESS [4:21.116s] > [INFO] Lens client ....................................... SUCCESS [20.821s] > [INFO] Lens CLI .......................................... SUCCESS [2:12.557s] > [INFO] Lens Examples ..................................... SUCCESS [0.877s] > [INFO] Lens Distribution ................................. SUCCESS [10.239s] > [INFO] Lens ML Lib ....................................... SUCCESS [42.718s] > [INFO] Lens Regression ................................... SUCCESS [0.460s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 13:14.098s > [INFO] Finished at: Tue Mar 24 07:22:39 UTC 2015 > [INFO] Final Memory: 109M/1216M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Rajat Khandelwal > >
