> On March 30, 2015, 9:01 a.m., Rajat Khandelwal wrote: > > lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java, > > line 476 > > <https://reviews.apache.org/r/32612/diff/1/?file=909072#file909072line476> > > > > These two cases started failing, should we add new tests for the > > purpose they originally were supposed to test?
Earlier those were getting accepted. With this change they are no more accepted. Do you know of any other purpose the tests were there? - Amareshwari ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32612/#review78185 ----------------------------------------------------------- On March 30, 2015, 7:27 a.m., Amareshwari Sriramadasu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32612/ > ----------------------------------------------------------- > > (Updated March 30, 2015, 7:27 a.m.) > > > Review request for lens and Rajat Khandelwal. > > > Bugs: LENS-342 > https://issues.apache.org/jira/browse/LENS-342 > > > Repository: lens > > > Description > ------- > > Was able to reproduce the NPE with newly added unit test. Have put the fix to > fail the cases of accessing same table with chain and without chain in a query > > > Diffs > ----- > > > lens-cube/src/main/java/org/apache/lens/cube/metadata/ReferencedDimAtrribute.java > 859b344 > > lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java > 2d239e1 > lens-cube/src/main/java/org/apache/lens/cube/parse/JoinResolver.java > 32a4b85 > lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java > 7d08212 > lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java > 1f03db6 > lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java > 0e5978e > > Diff: https://reviews.apache.org/r/32612/diff/ > > > Testing > ------- > > Waiting for test run to complete. All lens-cube tests passed. > > > Thanks, > > Amareshwari Sriramadasu > >
