----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32612/#review78199 -----------------------------------------------------------
Ship it! Ship It! - Rajat Khandelwal On March 30, 2015, 4:17 p.m., Amareshwari Sriramadasu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32612/ > ----------------------------------------------------------- > > (Updated March 30, 2015, 4:17 p.m.) > > > Review request for lens and Rajat Khandelwal. > > > Bugs: LENS-342 > https://issues.apache.org/jira/browse/LENS-342 > > > Repository: lens > > > Description > ------- > > Was able to reproduce the NPE with newly added unit test. Have put the fix to > fail the cases of accessing same table with chain and without chain in a query > > > Diffs > ----- > > > lens-cube/src/main/java/org/apache/lens/cube/metadata/ReferencedDimAtrribute.java > 859b344 > > lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java > 2d239e1 > lens-cube/src/main/java/org/apache/lens/cube/parse/JoinResolver.java > 32a4b85 > lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java > 7d08212 > lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java > 1f03db6 > lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java > 0e5978e > > Diff: https://reviews.apache.org/r/32612/diff/ > > > Testing > ------- > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.953s] > [INFO] Lens .............................................. SUCCESS [2.202s] > [INFO] Lens API .......................................... SUCCESS [5.928s] > [INFO] Lens API for server and extensions ................ SUCCESS [6.779s] > [INFO] Lens Cube ......................................... SUCCESS [2:14.088s] > [INFO] Lens DB storage ................................... SUCCESS [10.047s] > [INFO] Lens Query Library ................................ SUCCESS [4.582s] > [INFO] Lens Hive Driver .................................. SUCCESS [2:31.227s] > [INFO] Lens Driver for JDBC .............................. SUCCESS [17.883s] > [INFO] Lens Server ....................................... SUCCESS [6:11.844s] > [INFO] Lens client ....................................... SUCCESS [21.305s] > [INFO] Lens CLI .......................................... SUCCESS [2:03.898s] > [INFO] Lens Examples ..................................... SUCCESS [0.831s] > [INFO] Lens Distribution ................................. SUCCESS [9.314s] > [INFO] Lens ML Lib ....................................... SUCCESS [1:12.905s] > [INFO] Lens ML Ext Distribution .......................... SUCCESS [4.297s] > [INFO] Lens Regression ................................... SUCCESS [0.552s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 15:39.995s > [INFO] Finished at: Mon Mar 30 10:46:33 UTC 2015 > [INFO] Final Memory: 109M/1325M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Amareshwari Sriramadasu > >
