> On March 30, 2015, 9:33 a.m., Himanshu Gahlaut wrote: > > lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java, > > line 587 > > <https://reviews.apache.org/r/32612/diff/1/?file=909072#file909072line587> > > > > Could this be added as a separate test case ? It helps in making test > > cases modular. Increases readability and scope of number of test cases > > which can be run in parallel.
Added them together with earlier tests testing same functionality. Will move them to separate test. - Amareshwari ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32612/#review78187 ----------------------------------------------------------- On March 30, 2015, 7:27 a.m., Amareshwari Sriramadasu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32612/ > ----------------------------------------------------------- > > (Updated March 30, 2015, 7:27 a.m.) > > > Review request for lens and Rajat Khandelwal. > > > Bugs: LENS-342 > https://issues.apache.org/jira/browse/LENS-342 > > > Repository: lens > > > Description > ------- > > Was able to reproduce the NPE with newly added unit test. Have put the fix to > fail the cases of accessing same table with chain and without chain in a query > > > Diffs > ----- > > > lens-cube/src/main/java/org/apache/lens/cube/metadata/ReferencedDimAtrribute.java > 859b344 > > lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java > 2d239e1 > lens-cube/src/main/java/org/apache/lens/cube/parse/JoinResolver.java > 32a4b85 > lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java > 7d08212 > lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java > 1f03db6 > lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java > 0e5978e > > Diff: https://reviews.apache.org/r/32612/diff/ > > > Testing > ------- > > Waiting for test run to complete. All lens-cube tests passed. > > > Thanks, > > Amareshwari Sriramadasu > >
