----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30250/#review81275 -----------------------------------------------------------
lens-server-api/src/main/java/org/apache/lens/server/api/metrics/MetricsService.java <https://reviews.apache.org/r/30250/#comment131566> rename this to something like `getSessionsOpenedTillNow`? lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionEvent.java <https://reviews.apache.org/r/30250/#comment131567> Don't need `()` lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionOpened.java <https://reviews.apache.org/r/30250/#comment131568> can have @Getter private SessionStatus sessionStatus = SessionStatus.OPENED instead of overriding. Will save 4 lines. lens-server/src/main/java/org/apache/lens/server/LensService.java <https://reviews.apache.org/r/30250/#comment131569> Why make it public? lens-server/src/main/java/org/apache/lens/server/LensService.java <https://reviews.apache.org/r/30250/#comment131570> Let's not make extra method for just one service. Since corresponding methods for other services are not there. Plus it doesn't make sense to return an instance of a subclass from a superclass. lens-server/src/main/java/org/apache/lens/server/LensService.java <https://reviews.apache.org/r/30250/#comment131571> This call shouldn't be in `LensService`, it should be in `HiveSessionService` lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java <https://reviews.apache.org/r/30250/#comment131572> Don't need an extra call. Can merge the called function here itself. lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java <https://reviews.apache.org/r/30250/#comment131573> `openedSessions.inc()` lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java <https://reviews.apache.org/r/30250/#comment131575> Also, `openedSessions.inc()` lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java <https://reviews.apache.org/r/30250/#comment131576> also, `openedSessions.dec()` lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java <https://reviews.apache.org/r/30250/#comment131577> +1 lens-server/src/test/java/org/apache/lens/server/query/TestEventService.java <https://reviews.apache.org/r/30250/#comment131578> Instead of keeping a boolean, should we keep an integer so that we can verify how many times the function was hit. - Rajat Khandelwal On April 22, 2015, 6:52 a.m., Raju Bairishetti wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30250/ > ----------------------------------------------------------- > > (Updated April 22, 2015, 6:52 a.m.) > > > Review request for lens, Amareshwari Sriramadasu and Jaideep dhok. > > > Bugs: LENS-186 > https://issues.apache.org/jira/browse/LENS-186 > > > Repository: lens > > > Description > ------- > > If a service is maintaining some session specific data events like session > started or session closed would be useful for init/cleanup of resources. > > This would be also useful in maintaining session history. > > > Diffs > ----- > > > lens-server-api/src/main/java/org/apache/lens/server/api/metrics/MetricsService.java > 71a1f5b > > lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionClosed.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionEvent.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionExpired.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionOpened.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionRestored.java > PRE-CREATION > lens-server/src/main/java/org/apache/lens/server/LensService.java bd8699b > > lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java > 90137e1 > > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java > cd1fbd8 > > lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java > e4fb812 > > lens-server/src/test/java/org/apache/lens/server/query/TestEventService.java > ec752ff > > lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java > 00df104 > > Diff: https://reviews.apache.org/r/30250/diff/ > > > Testing > ------- > > Added a unit test in TestEventService > > > Thanks, > > Raju Bairishetti > >
