> On April 23, 2015, 7 a.m., Rajat Khandelwal wrote: > > lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java, > > line 213 > > <https://reviews.apache.org/r/30250/diff/3/?file=939007#file939007line213> > > > > `openedSessions.inc()`
openedSessions is a guage metric. It gets the value from SESSION_MAP > On April 23, 2015, 7 a.m., Rajat Khandelwal wrote: > > lens-server/src/main/java/org/apache/lens/server/LensService.java, line 160 > > <https://reviews.apache.org/r/30250/diff/3/?file=939006#file939006line160> > > > > Let's not make extra method for just one service. Since corresponding > > methods for other services are not there. Plus it doesn't make sense to > > return an instance of a subclass from a superclass. This is an existing getter method in QueryExecutionServiceImpl. I just moved the method to here to make it available to SessionService as well. > On April 23, 2015, 7 a.m., Rajat Khandelwal wrote: > > lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionOpened.java, > > line 49 > > <https://reviews.apache.org/r/30250/diff/3/?file=939004#file939004line49> > > > > can have > > > > @Getter private SessionStatus sessionStatus = SessionStatus.OPENED > > > > instead of overriding. Will save 4 lines. +1 - Raju ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30250/#review81275 ----------------------------------------------------------- On April 22, 2015, 1:22 a.m., Raju Bairishetti wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30250/ > ----------------------------------------------------------- > > (Updated April 22, 2015, 1:22 a.m.) > > > Review request for lens, Amareshwari Sriramadasu and Jaideep dhok. > > > Bugs: LENS-186 > https://issues.apache.org/jira/browse/LENS-186 > > > Repository: lens > > > Description > ------- > > If a service is maintaining some session specific data events like session > started or session closed would be useful for init/cleanup of resources. > > This would be also useful in maintaining session history. > > > Diffs > ----- > > > lens-server-api/src/main/java/org/apache/lens/server/api/metrics/MetricsService.java > 71a1f5b > > lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionClosed.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionEvent.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionExpired.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionOpened.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionRestored.java > PRE-CREATION > lens-server/src/main/java/org/apache/lens/server/LensService.java bd8699b > > lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java > 90137e1 > > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java > cd1fbd8 > > lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java > e4fb812 > > lens-server/src/test/java/org/apache/lens/server/query/TestEventService.java > ec752ff > > lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java > 00df104 > > Diff: https://reviews.apache.org/r/30250/diff/ > > > Testing > ------- > > Added a unit test in TestEventService > > > Thanks, > > Raju Bairishetti > >
