> On April 23, 2015, 7 a.m., Rajat Khandelwal wrote: > > lens-server/src/main/java/org/apache/lens/server/LensService.java, line 79 > > <https://reviews.apache.org/r/30250/diff/3/?file=939006#file939006line79> > > > > Why make it public?
Reverted to protected. Added a getter for only getting the numberofSessions. > On April 23, 2015, 7 a.m., Rajat Khandelwal wrote: > > lens-server-api/src/main/java/org/apache/lens/server/api/metrics/MetricsService.java, > > line 165 > > <https://reviews.apache.org/r/30250/diff/3/?file=939000#file939000line165> > > > > rename this to something like `getSessionsOpenedTillNow`? I think getSessionsOpened**TillNow** conveys how many sessions were opened from the start of server instead of how many sessions are active(opened) at that moment. > On April 23, 2015, 7 a.m., Rajat Khandelwal wrote: > > lens-server/src/test/java/org/apache/lens/server/query/TestEventService.java, > > line 261 > > <https://reviews.apache.org/r/30250/diff/3/?file=939010#file939010line261> > > > > Instead of keeping a boolean, should we keep an integer so that we can > > verify how many times the function was hit. The events are generated from the unit test itself. We are calling only once. It just tests the event listener like Whether events are received when they triggered. We have a unit test for session metrics. - Raju ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30250/#review81275 ----------------------------------------------------------- On April 23, 2015, 11:52 p.m., Raju Bairishetti wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30250/ > ----------------------------------------------------------- > > (Updated April 23, 2015, 11:52 p.m.) > > > Review request for lens, Amareshwari Sriramadasu and Jaideep dhok. > > > Bugs: LENS-186 > https://issues.apache.org/jira/browse/LENS-186 > > > Repository: lens > > > Description > ------- > > If a service is maintaining some session specific data events like session > started or session closed would be useful for init/cleanup of resources. > > This would be also useful in maintaining session history. > > > Diffs > ----- > > > lens-server-api/src/main/java/org/apache/lens/server/api/metrics/MetricsService.java > 71a1f5b > > lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionClosed.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionEvent.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionExpired.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionOpened.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionRestored.java > PRE-CREATION > lens-server/src/main/java/org/apache/lens/server/LensService.java bd8699b > > lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java > 90137e1 > > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java > cd1fbd8 > > lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java > e4fb812 > > lens-server/src/test/java/org/apache/lens/server/query/TestEventService.java > ec752ff > > lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java > 00df104 > > Diff: https://reviews.apache.org/r/30250/diff/ > > > Testing > ------- > > Added a unit test in TestEventService > > > Thanks, > > Raju Bairishetti > >
