----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33581/#review81787 -----------------------------------------------------------
lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactHQLContext.java <https://reviews.apache.org/r/33581/#comment132265> This requires users to remove dangling latest partitions from storage fact tables. Should partition timeline update take care of removing latest partitions from metastore? lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java <https://reviews.apache.org/r/33581/#comment132266> With partial and no data, isnt this going to be double lookup? Shouldnt we simply check if the table is partitioned by the part column, if not then fallback to fallback part column? lens-cube/src/main/java/org/apache/lens/cube/parse/TimeRange.java <https://reviews.apache.org/r/33581/#comment132267> With custom timerange writer wouldnt this cause any issue? lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java <https://reviews.apache.org/r/33581/#comment132264> Can we update example sales_aggr_fact2 also? sales_aggr_fact2 has partitioning scheme only on one time dimension. - Amareshwari Sriramadasu On April 28, 2015, 9:35 a.m., Rajat Khandelwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33581/ > ----------------------------------------------------------- > > (Updated April 28, 2015, 9:35 a.m.) > > > Review request for lens. > > > Bugs: LENS-198 > https://issues.apache.org/jira/browse/LENS-198 > > > Repository: lens > > > Description > ------- > > posting for early comments. > > > Diffs > ----- > > > lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreConstants.java > 74a26feec12cd3630ab06d8a714ad05fcec9e9ec > lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java > 8e2c9ed23670934a76d931ad6eb018bcf203dedf > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java > 47b9fc1ed678550d929b234bb6742635390df8ba > lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java > b7c3ee95f7275f78b5e87377de59720f1bdd9ade > lens-cube/src/main/java/org/apache/lens/cube/parse/DateUtil.java > 82c43a7387b87d98cfd64dde4c85e0a4c5d6834c > lens-cube/src/main/java/org/apache/lens/cube/parse/DimHQLContext.java > e200b12ae7bcef800c138c0db2b3ceb0d0b028ef > lens-cube/src/main/java/org/apache/lens/cube/parse/DimOnlyHQLContext.java > 8a23dedfbd6bba03099eceb7f44a6acf20dc0a62 > lens-cube/src/main/java/org/apache/lens/cube/parse/FactHQLContext.java > 766769f64da062ab4417745cdd1ef110fe0bf933 > > lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactHQLContext.java > beaa5517d67dcb4561bd8fad8fc0a304d36b0ca2 > > lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java > 70296aa71585ea8a8f8a74db3ecaa05981228719 > lens-cube/src/main/java/org/apache/lens/cube/parse/TimeRange.java > 612cdf9b39f82efea0f8197f1daabe4a85994775 > lens-cube/src/main/java/org/apache/lens/cube/parse/TimerangeResolver.java > c73b7ffae47834eb6e0d84f56df7de8400641745 > lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java > 5d9e97ecea541e0d82a22ab8365f79f2983d6695 > lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java > 097f2283b7defb2fe5703cf04f3dc276f18e341b > > Diff: https://reviews.apache.org/r/33581/diff/ > > > Testing > ------- > > > Thanks, > > Rajat Khandelwal > >
