-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33581/
-----------------------------------------------------------

(Updated May 4, 2015, 5 p.m.)


Review request for lens.


Summary (updated)
-----------------

LENS:198: Allow timed dimensions of cube to be non-partitioned columns as well


Bugs: LENS-198
    https://issues.apache.org/jira/browse/LENS-198


Repository: lens


Description
-------

posting for early comments.


Diffs (updated)
-----

  
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java 
fbdefab3910c03e06cba082fc0677296de4f7415 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/FactPartition.java 
8a6dcbabff70d6cfa5a3ef2e434fda50ef397770 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreConstants.java 
74a26feec12cd3630ab06d8a714ad05fcec9e9ec 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java 
8e2c9ed23670934a76d931ad6eb018bcf203dedf 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/TimePartition.java 
8f088c0fde5063687482244648e526e145ec4d1a 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/TimePartitionRange.java 
86c3453473d7f0f8ac597aa82f007e721bcdd675 
  
lens-cube/src/main/java/org/apache/lens/cube/metadata/TimePartitionRangeList.java
 PRE-CREATION 
  
lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/PartitionTimeline.java
 237164fd92a4bd1355cef6d90319328cafa3b9d4 
  
lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/RangesPartitionTimeline.java
 24f7f1a5b05b53d268286253b41ac271c4adfa85 
  lens-cube/src/main/java/org/apache/lens/cube/parse/AliasReplacer.java 
961faad9b2bd9d212654707f6591822a8f3ac561 
  lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java 
47b9fc1ed678550d929b234bb6742635390df8ba 
  
lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java
 165525d083f78b1c6a00fec6811efb3549c696b8 
  lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java 
b7c3ee95f7275f78b5e87377de59720f1bdd9ade 
  lens-cube/src/main/java/org/apache/lens/cube/parse/DateUtil.java 
82c43a7387b87d98cfd64dde4c85e0a4c5d6834c 
  
lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java 
f5d2115d885cc7a88061543267f0d6c49882d884 
  lens-cube/src/main/java/org/apache/lens/cube/parse/DimHQLContext.java 
e200b12ae7bcef800c138c0db2b3ceb0d0b028ef 
  lens-cube/src/main/java/org/apache/lens/cube/parse/DimOnlyHQLContext.java 
8a23dedfbd6bba03099eceb7f44a6acf20dc0a62 
  lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java 
fa23b8e42452552c9d400fcfa20d5d099458ffbc 
  lens-cube/src/main/java/org/apache/lens/cube/parse/FactHQLContext.java 
766769f64da062ab4417745cdd1ef110fe0bf933 
  lens-cube/src/main/java/org/apache/lens/cube/parse/FieldValidator.java 
eafd661aef84fefb06e8e4a500758bd7826f0567 
  lens-cube/src/main/java/org/apache/lens/cube/parse/JoinResolver.java 
a41424a06a904a08b4f0c8ac294a6eebdf7902e6 
  
lens-cube/src/main/java/org/apache/lens/cube/parse/MaxCoveringFactResolver.java 
e3a90d51703f31cdfcd0fc4cb089bb43dd3423e2 
  lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactHQLContext.java 
beaa5517d67dcb4561bd8fad8fc0a304d36b0ca2 
  lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java 
70296aa71585ea8a8f8a74db3ecaa05981228719 
  lens-cube/src/main/java/org/apache/lens/cube/parse/TimeRange.java 
612cdf9b39f82efea0f8197f1daabe4a85994775 
  lens-cube/src/main/java/org/apache/lens/cube/parse/TimerangeResolver.java 
c73b7ffae47834eb6e0d84f56df7de8400641745 
  lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 
5d9e97ecea541e0d82a22ab8365f79f2983d6695 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java 
b1d7a3203ad5e169930a3dddf6a9fdf55d5cc66a 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 
097f2283b7defb2fe5703cf04f3dc276f18e341b 
  
lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java
 c9972e23419a00fb5729b854b8feea9b44b125a3 
  
lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeExtractor.java 
f19221b0548196b3a88dd0451ed24035696e6e35 
  lens-examples/src/main/resources/sales-cube.xml 
951ace98e7872e60395f3c3201ea2ecf8e03d577 

Diff: https://reviews.apache.org/r/33581/diff/


Testing
-------


Thanks,

Rajat Khandelwal

Reply via email to