Jörn Nettingsmeier wrote:

Michael Wechner wrote:

Jörn Nettingsmeier wrote:

hi everyone!


src/webapp/lenya/bin/ contains some sftp control files and unix shellscripts. they don't seem to be very generic, so i guess they are probably not useful for anybody anymore...

copy-recursive.sh
  this seems to be a very convoluted way of doing scp -r...
replicate.sh
  a script to batch-copy a tomcat-deployed publication?
sftp-copy-children.txt
sftp-copy-index.txt
sftp-mkdir-children.txt
  sftp command batch files, not generic
sftp.sh
  a wrapper for sftp -b :o)
tomcatctrl
  a system-v style init script for tomcat. should come with all sane
  distros nowadays.



I think these utilities are very useful at least when using Lenya within a productive environment.


the problem is that it's not clear to anyone but the author what exactly they are useful for, and it seems that at least the sftp stuff is needlessly complicated (it really doesn't seem to do much more than a recursive copy, which can easily be done with scp -r).


there are some cases which don't have ssl installed which one can use directly, but ftp resp. sftp is available on these servers. That's just a fact which I cannot do much about.

all in all, the scripts look like somebody's very personal toolkit...


these are utilities which for instance we use for our customers and ourselves within productive environments


one other thing i do not understand is why these scripts are deployed to the webapp... sounds like a really bad idea to me.


I guess that wasn't on purpose


another thing worth considering is the fact that we aim to be cross-platform. that means it does not make much sense to keep unix scripts around when there's no windows equivalent.


why not? At least one has something for UNIX and might be a good start for someone creating something similar for Windows.


it's not clear whether this stuff is really up-to-date and still working.


AFAIK most of it is working

if you can do some tests and add a few comments that explain what it's all about


I think the names and targets are self-explaining and some of them also contain usage instructions

and will make the code useful for everybody, i'm all for keeping it. but i'd rather not keep untested code in the trunk that has fallen into disuse and does not get regular testing.

if nobody has any objections, i'll remove the entire bin directory from the core. if people do see a need to haul small utility scripts around, we should create a new directory like "util" directly below trunk/, but i don't see why we should have them in the core tree.



moving them out of the core makes sense, but I am -1 on deleting them.


ok. for now i'll be moving it into a trunk/utils directory and remove them from the deployment targets, but the stuff stays on my list unless users of that code speak up and review and comment it a little within the next 2 weeks or so.


well, I won't have the time to do this, but I guess it doesn't make sense to argue much anyway, because the majority seems to want to get rid of it anyway. I will copy it to our public Wyona SVN and in case you will ever need such a utility you are welcome to download it.

Cheers

Michael



chim-chiminey, chim-chiminey, chim chim cheree
a sweep is as lucky as lucky can be. :-D


jörn





--
Michael Wechner
Wyona      -   Open Source Content Management   -    Apache Lenya
http://www.wyona.com                      http://lenya.apache.org
[EMAIL PROTECTED]                        [EMAIL PROTECTED]
+41 44 272 91 61


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to