[
https://issues.apache.org/jira/browse/LIBCLOUD-121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13133708#comment-13133708
]
Tomaz Muraus commented on LIBCLOUD-121:
---------------------------------------
I have partially applied your patch with Network class in r1187946
(http://svn.apache.org/viewvc?view=revision&revision=1187946). I have added the
network class to the OpenNebula driver and called it OpenNebulaNetwork. The
method for listing the networks is called ex_list_networks.
This can be changed once we decide about the unified networking API.
Some other things I have changed:
- extra={'address': element.findtext('ADRESS'), -> extra={'address':
element.findtext('ADDRESS') - I assume "ADRESS" was a typo or does the API
really return "ADRESS"?
- NodeNetwork(id=element.attrib['network'] ->
OpenNebulaNetwork(id=element.attrib.get('network', None)
- networkElement -> network_element, networkList -> network_list - we follow
PEP8 and use underscore separated names
I won't mark this ticket as closed yet, because we are still missing test. If
you want to get this patch included in the 0.6.0, release please add tests
during this week.
Also always make sure you generate the patch against Apache trunk version. It
looks like this one was generated against one of your branches with local
modifications which aren't in the trunk which means I needed to apply it
manually.
> OpenNebula Driver Improvements and Additional Driver Updates
> ------------------------------------------------------------
>
> Key: LIBCLOUD-121
> URL: https://issues.apache.org/jira/browse/LIBCLOUD-121
> Project: Libcloud
> Issue Type: Improvement
> Components: Core
> Affects Versions: 0.6.0
> Environment: Latest Libcloud trunk with contents of diff operating on
> Debian 6.0 (Stable).
> Reporter: Hutson Betts
> Priority: Minor
> Labels: api-change, patch
> Attachments: base-update.diff, opennebula.diff, update.diff
>
>
> I'm attaching a diff/patch that contains modifications to several compute
> drivers; OpenNebula in particular.
> With regard to OpenNebula, these changes include the ability to request a
> list of virtual networks provided by the OpenNebula infrastructure provider.
> Furthermore, the OpenNebula NodeDriver has been extended to extract the disk
> and network descriptions from the compute XML description. Disks and networks
> are instantiated as NodeImage and NodeNetwork objects and then attached to a
> newly instantiated Node. To support this capability, I added a NodeNetwork
> class to the base compute class.
> Furthermore, I modified the Opsource and OpenStack drivers to match in
> consistency with the OpenNebula driver. This also included changes to include
> httplib. I hope to extend that work later to other drivers, if the work is
> desired.
> This patch really requires additional, more in-depth testing, during this
> following week, but I wanted to present that patch for consideration, and
> comments.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
