The OpenNebula files comply with PEP8. Furthermore, the changes I made, to the best of my ability, also comply with PEP8. However, several of the files I modified, such as the bluebox.py driver, have lots of existing PEP8 issues which I did not resolve.
Tests pass as well:
Ran 1161 tests in 11.487s
OK
As for enforcing ID as a string, the Node class in compute/base.py
already does the enforcement:
self.id = str(id) if id else None
Therefore, I though enforcing the type in the driver would be redundant.
If it's alright to leave enforcement to the Node class, I'll begin the
process of setting up SVN on a system of mine, and I'll push the patch
to the trunk.
--
Hutson Betts
Computer Science and Engineering
Texas A&M University
On Fri, 2011-12-02 at 17:45 +0000, Tomaz Muraus (Commented) (JIRA)
wrote:
> [
> https://issues.apache.org/jira/browse/LIBCLOUD-121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13161745#comment-13161745
> ]
>
> Tomaz Muraus commented on LIBCLOUD-121:
> ---------------------------------------
>
> Looks OK. If all the tests and pep8 tool passes, I'd say merge it.
>
> Edit: Just noticed:
>
> + return Node(id=compute.findtext('ID'),
>
> We should enforce that node id is always a string:
>
> + return Node(id=str(compute.findtext('ID')),
>
>
> > OpenNebula Driver Improvements and Additional Driver Updates
> > ------------------------------------------------------------
> >
> > Key: LIBCLOUD-121
> > URL: https://issues.apache.org/jira/browse/LIBCLOUD-121
> > Project: Libcloud
> > Issue Type: Improvement
> > Components: Core
> > Affects Versions: 0.6.1
> > Environment: Latest Libcloud trunk with contents of diff operating
> > on Debian 6.0 (Stable).
> > Reporter: Hutson Betts
> > Priority: Minor
> > Labels: api-change, patch
> > Attachments: base-update.diff, opennebula.diff, opennebula.patch,
> > opennebula.patch, update.diff
> >
> >
> > I'm attaching a diff/patch that contains modifications to several compute
> > drivers; OpenNebula in particular.
> > With regard to OpenNebula, these changes include the ability to request a
> > list of virtual networks provided by the OpenNebula infrastructure
> > provider. Furthermore, the OpenNebula NodeDriver has been extended to
> > extract the disk and network descriptions from the compute XML description.
> > Disks and networks are instantiated as NodeImage and NodeNetwork objects
> > and then attached to a newly instantiated Node. To support this capability,
> > I added a NodeNetwork class to the base compute class.
> > Furthermore, I modified the Opsource and OpenStack drivers to match in
> > consistency with the OpenNebula driver. This also included changes to
> > include httplib. I hope to extend that work later to other drivers, if the
> > work is desired.
> > This patch really requires additional, more in-depth testing, during this
> > following week, but I wanted to present that patch for consideration, and
> > comments.
>
> --
> This message is automatically generated by JIRA.
> If you think it was sent incorrectly, please contact your JIRA
> administrators:
> https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
> For more information on JIRA, see: http://www.atlassian.com/software/jira
>
>
signature.asc
Description: This is a digitally signed message part
