[
https://issues.apache.org/jira/browse/LIBCLOUD-121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13161717#comment-13161717
]
Tomaz Muraus commented on LIBCLOUD-121:
---------------------------------------
Really sorry for the delay, I was pretty busy recently.
Overall the patch looks good, here are a few minor things I have noticed:
1.
+ def __init__(self, *args, **kwargs):
+ # done because of a circular reference from
+ # NodeDriver -> Connection -> Response
+ self.connection = OpenNebulaConnection
+ super(OpenNebulaResponse, self).__init__(*args, **kwargs)
+
Is there a nicer way to get rid of the cycling dependency?
2.
+ elif api_version == '2.0' or api_version == '2.2' or \
+ api_version == '3.0' or api_version == '3.2':
+
Can be written as:
elif api_version in ['2.0', '2.2', '3.0', '3.2'] ...
> OpenNebula Driver Improvements and Additional Driver Updates
> ------------------------------------------------------------
>
> Key: LIBCLOUD-121
> URL: https://issues.apache.org/jira/browse/LIBCLOUD-121
> Project: Libcloud
> Issue Type: Improvement
> Components: Core
> Affects Versions: 0.6.1
> Environment: Latest Libcloud trunk with contents of diff operating on
> Debian 6.0 (Stable).
> Reporter: Hutson Betts
> Priority: Minor
> Labels: api-change, patch
> Attachments: base-update.diff, opennebula.diff, opennebula.patch,
> update.diff
>
>
> I'm attaching a diff/patch that contains modifications to several compute
> drivers; OpenNebula in particular.
> With regard to OpenNebula, these changes include the ability to request a
> list of virtual networks provided by the OpenNebula infrastructure provider.
> Furthermore, the OpenNebula NodeDriver has been extended to extract the disk
> and network descriptions from the compute XML description. Disks and networks
> are instantiated as NodeImage and NodeNetwork objects and then attached to a
> newly instantiated Node. To support this capability, I added a NodeNetwork
> class to the base compute class.
> Furthermore, I modified the Opsource and OpenStack drivers to match in
> consistency with the OpenNebula driver. This also included changes to include
> httplib. I hope to extend that work later to other drivers, if the work is
> desired.
> This patch really requires additional, more in-depth testing, during this
> following week, but I wanted to present that patch for consideration, and
> comments.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
