For those who may not be watching our Github repo, a patch was submitted
yesterday on Github to fix the redirect problem.  I downloaded the patch to
the Discourse SSO branch I've been working with, and Sidney is now able to
login properly the first time she clicks on "Log In" from Discourse:  She
gets redirected to the login, enters her credentials, clicks
"Log in", and *ultimately* gets redirected back to Discourse logged in
(technically, a bit more in depth than that, but that's ok).

There were concerns presented that this broke things previously, which is
why it was changed.  Based on what we have now, it appears to be working.
I'll test a little bit more manually for now, but ultimately, we need some
automated tests written to make sure this works.  I have not learned how to
write unit tests, so if someone else is up for the challenge OR if someone
wants to spend time showing me how to do so, I would definitely appreciate
the help.

If someone can get me a patch for the unit tests, I can bundle up all the
various patches into one MR back to and help Salt get
this up and running.


- Jason

On Tue, Dec 6, 2016 at 2:11 PM, Stephen Michel <>

> On Tue, Dec 6, 2016 at 12:30 PM, fr33domlover <>
> wrote:
>> So, Bryan, waiting for your input on this. For now, I suppose it's not
>> super
>> critical, but it definitely will annoy and confuse users once the
>> Discourse
>> instance starts getting filled with people and messages (or is it
>> alreday? I
>> didn't check).
>> -- fr33
> When last I heard, the plan was to completely wipe the current Discourse
> instance and start clean with SSO. To that end, I believe the only people
> with accounts on Discourse are team members who have been manually invited.
> I'm not the most in the loop, so take this a grain of salt.
> ~Stephen
> _______________________________________________
> Dev mailing list
Dev mailing list

Reply via email to