Dear Mikko,
As I commented on the gerrit request, https://review.tizen.org/gerrit/#/c/10439/1, I am the reviewer for the code merge. As you already mentioned valuable comments, there is some issue with current source code.
In my opinion, some changes like the current review should be applied on the code but it should be separate review request, not the merge commit. The merge commit itself has its own meaning of merging some patch sets and it should be distinguinished from the changes itself. (If the merge is not proper, then each changes should be cherry-picked for the small changes.)
If you agree with me, then I will ask the developer to submit another request for aul git.
Thanks,
Young
------- Original Message -------
Sender : Ylinen, Mikko<[email protected]>
Date : 2013-10-04 15:34 (GMT+09:00)
Title : Re: [Dev] code dumps without proper review
Going forward we should NOT accept any code dump requests unless developer provides sufficient evidence of successful build.
|
|
_______________________________________________ Dev mailing list [email protected] https://lists.tizen.org/listinfo/dev
