Re: [Dev] code dumps without proper review

Tue, 08 Oct 2013 01:11:17 -0700

Title: Samsung Enterprise Portal mySingle

Mikko,

 

On the merge commit, the following two files should be resurrected:

packaging/aul.changes

packaging/aul.manifest

 

I understand that the location for SMACK manifest file is moved under packaging directory. However, there exists duplicated files of ac.service/ac_user.service and [email protected]/launchpad-preload_user.service. I am not quite sure which of them are used in reality. Would you give me any clue, especially for IVI profile, please?

 

Thanks,

Young

 

 

------- Original Message -------

Sender : Ylinen, Mikko<[email protected]>

Date : 2013-10-08 15:18 (GMT+09:00)

Title : Re: Re: [Dev] code dumps without proper review

 


Hi Young,

On Mon, Oct 7, 2013 at 2:53 PM, 조영익 <[email protected]> wrote:

As I commented on the gerrit request, https://review.tizen.org/gerrit/#/c/10439/1, I am the reviewer for the code merge. As you already mentioned valuable comments, there is some issue with current source code.

 

In my opinion, some changes like the current review should be applied on the code but it should be separate review request, not the merge commit. The merge commit itself has its own meaning of merging some patch sets and it should be distinguinished from the changes itself. (If the merge is not proper, then each changes should be cherry-picked for the small changes.)

 

If you agree with me, then I will ask the developer to submit another request for aul git.

I'm not sure I follow the proposal here. Overall, I think the most recent tizen_2.2 merge is bad
because it deletes files that have been in 'tizen' for a long time.

Mikko
 

 

 

 

_______________________________________________
Dev mailing list
[email protected]
https://lists.tizen.org/listinfo/dev

Reply via email to