If it is just a test failing due to a change to the ListAppender I don’t think I’d want to create another RC due to a test failing due to an error or behavioral change introduced in a test class.
Ralph > On Aug 7, 2019, at 7:46 AM, Gary Gregory <[email protected]> wrote: > > On Wed, Aug 7, 2019 at 10:37 AM Matt Sicker <[email protected]> wrote: > >> I believe I've figured out the regression. It was a behavioral change >> documented in https://issues.apache.org/jira/browse/LOG4J2-2527 and >> thus isn't a regression. >> >> I'll continue reviewing. >> > > Are you then saying that the failing test is expected? If yes, then surely > then the test should be updated and another RC prepared, right? > > Gary > > >> On Wed, 7 Aug 2019 at 09:26, Matt Sicker <[email protected]> wrote: >>> >>> There seems to be a regression somewhere that was introduced in a >>> previous release between 2.11.1 and this version. Or it could be that >>> the code I'm testing out relied on a bug. I haven't figured out the >>> issue yet, though it's strange so far. >>> >>> On Wed, 7 Aug 2019 at 08:31, Gary Gregory <[email protected]> >> wrote: >>>> >>>> Based on the tag git checkout tags/log4j-2.12.1-rc1 >>>> >>>> Apache RAT check OK >>>> >>>> I could not find a way to run the CLIRR check on the log4j-api module. >>>> >>>> Running 'mvn clean install' OK using: >>>> >>>> Apache Maven 3.6.1 (d66c9c0b3152b2e69ee9bac180bb8fcc8e6af555; >>>> 2019-04-04T15:00:29-04:00) >>>> Maven home: C:\Java\apache-maven-3.6.1\bin\.. >>>> Java version: 1.8.0_221, vendor: Oracle Corporation, runtime: >> C:\Program >>>> Files\Java\jdk1.8.0_221\jre >>>> Default locale: en_US, platform encoding: Cp1252 >>>> OS name: "windows 10", version: "10.0", arch: "amd64", family: >> "windows" >>>> >>>> Can anyone reproduce this: >>>> >>>> [ERROR] Failures: >>>> [ERROR] AbstractActionTest.testExceptionsAreLoggedToStatusLogger:48 >>>> [INFO] >>>> [ERROR] Tests run: 2060, Failures: 1, Errors: 0, Skipped: 26 >>>> [INFO] >>>> [INFO] >>>> >> ------------------------------------------------------------------------ >>>> [INFO] Reactor Summary for Apache Log4j 2 2.12.1: >>>> [INFO] >>>> [INFO] Apache Log4j 2 ..................................... SUCCESS [ >>>> 2.535 s] >>>> [INFO] Apache Log4j API Java 9 support .................... SUCCESS [ >>>> 5.745 s] >>>> [INFO] Apache Log4j API ................................... SUCCESS >> [01:12 >>>> min] >>>> [INFO] Apache Log4j Implementation Java 9 support ......... SUCCESS [ >>>> 2.341 s] >>>> [INFO] Apache Log4j Core .................................. FAILURE >> [15:59 >>>> min] >>>> >>>> ? >>>> >>>> Gary >>>> >>>> >>>> >>>> On Wed, Aug 7, 2019 at 1:43 AM Ralph Goers <[email protected] >>> >>>> wrote: >>>> >>>>> This is a vote to release Log4j 2.12.1, the next version of the >> Log4j 2 >>>>> project. >>>>> >>>>> Please download, test, and cast your votes on the log4j developers >> list. >>>>> [] +1, release the artifacts >>>>> [] -1, don't release because... >>>>> >>>>> The vote will remain open for 72 hours (or more if required). All >> votes >>>>> are welcome and we encourage everyone to test the release, but only >> Logging >>>>> PMC votes are “officially” counted. As always, at least 3 +1 votes >> and more >>>>> positive than negative votes are required. >>>>> >>>>> Changes in this release include: >>>>> >>>>> Fixed Bugs >>>>> >>>>> • LOG4J2-1946: Allow file renames to work when files are >> missing >>>>> from the sequence. Thanks to Igor Perelyotov. >>>>> • LOG4J2-2650: Support emulating a MAC address when using >> ipv6. >>>>> Thanks to Mattia Bertorello. >>>>> • LOG4J2-2366: Remove references to LoggerContext when it is >>>>> shutdown. >>>>> • LOG4J2-2644: Improve the performance of capturing location >>>>> information. >>>>> • LOG4J2-2658: AbstractAction.reportException records a >> warning to >>>>> the status logger, providing more information when file based >> appenders >>>>> fail to compress rolled data asynchronously. >>>>> • LOG4J2-2659: AbstractAction handles and records unchecked >>>>> RuntimeException and Error in addition to IOException. >>>>> • LOG4J2-2667: Values not bound to statement" when using JDBC >>>>> appender, appender does not respect bufferSize=“0”. Thanks to Edith >> Chui. >>>>> >>>>> Changes >>>>> >>>>> • LOG4J2-2556: Make Log4j Core optional for Log4j 1.2 API. >>>>> • LOG4J2-2646: Update MongoDB 3 driver from 3.10.1 to 3.10.2. >>>>> • LOG4J2-2657: Improve exception messages in the JDBC >> appender. >>>>> • LOG4J2-2660: Retry when JDBC throws a >>>>> java.sql.SQLTransactionRollbackException in commitAndClose(). >>>>> >>>>> Tag: >>>>> a) for a new copy do "git clone >>>>> https://github.com/apache/logging-log4j2.git"; and then "git checkout >>>>> tags/log4j-2.12.1-rc1” >>>>> b) for an existing working copy to “git pull” and then “git checkout >>>>> tags/log4j-2.12.1-rc1” >>>>> >>>>> Web Site: http://rgoers.github.io/log4j2-site/index.html. >>>>> >>>>> Maven Artifacts: >>>>> >> https://repository.apache.org/content/repositories/orgapachelogging-1048 >>>>> >>>>> Distribution archives: >>>>> https://dist.apache.org/repos/dist/dev/logging/log4j/ >>>>> >>>>> You may download all the Maven artifacts by executing: >>>>> wget -e robots=off --cut-dirs=7 -nH -r -p -np --no-check-certificate >>>>> >> https://repository.apache.org/content/repositories/orgapachelogging-1048/org/apache/logging/log4j/ >>>>> >>>>> Ralph >>>>> >>> >>> >>> >>> -- >>> Matt Sicker <[email protected]> >> >> >> >> -- >> Matt Sicker <[email protected]> >>
