[ 
https://issues.apache.org/jira/browse/LUCENE-2649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12910513#action_12910513
 ] 

Michael McCandless commented on LUCENE-2649:
--------------------------------------------

Looks great!

Should we make it optional, whether the valid bitset should be computed?  Many 
apps wouldn't need it, so it just ties up (admittedly smallish amounts of) RAM 
unnecessarily?

bq. Lucene's sorting Collectors can be improved to have a consistent behaviour 
for missing values (like Solr's sortMissingFirst/Last).

+1

Shouldn't we pull Solr's sortMissingFirst/Last down into Lucene?

> FieldCache should include a BitSet for matching docs
> ----------------------------------------------------
>
>                 Key: LUCENE-2649
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2649
>             Project: Lucene - Java
>          Issue Type: Improvement
>            Reporter: Ryan McKinley
>             Fix For: 4.0
>
>         Attachments: LUCENE-2649-FieldCacheWithBitSet.patch, 
> LUCENE-2649-FieldCacheWithBitSet.patch
>
>
> The FieldCache returns an array representing the values for each doc.  
> However there is no way to know if the doc actually has a value.
> This should be changed to return an object representing the values *and* a 
> BitSet for all valid docs.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to