[
https://issues.apache.org/jira/browse/LUCENE-2649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12913485#action_12913485
]
Michael McCandless commented on LUCENE-2649:
--------------------------------------------
bq. Also set the Lucene default to true
Please don't!
bq. as I want to improve sorting and FCRF.
But: sorting, FCRF must continue to work if the app chooses not to
load valid bits, right?
Other feedback on current patch:
* We don't have to @Deprecate for 4.0 -- just remove it, and note
this in MIGRATE.txt. (Though for 3.x we need the deprecation, so
maybe do 3.x patch first, then remove deprecations for 4.0?).
* FieldCache.EntryCreator looks orphan'd?
It looks like the valid bits will not reflect deletions (by design),
right? Ie caller cannot rely on valid always incorporating deleted
docs. (Eg the MatchAll opto disregards deletions, and, a reopened
segment can have new deletions yet shares the FC entry).
The static config still also bothers me... and, going that route means
we must agree on a default (which is looking hard!).
What if we:
* Allow specifying "loadValidBits" on each load (eg via Parser or
separate arg to FC.getXXValues), but,
* We separately cache the valid bits (we'd still have the XXXValues
returned, to include the valid bits & values).
This way if an app "messes up", they do not end up double-storing the
actual values, ie the worst that happens is they have to re-invert
just to generate the valid bits. Even that should be fairly rare, ie,
if they use MissingStringLastComparator it'll init both values & valid
bits entries in the cache on the first go.
> FieldCache should include a BitSet for matching docs
> ----------------------------------------------------
>
> Key: LUCENE-2649
> URL: https://issues.apache.org/jira/browse/LUCENE-2649
> Project: Lucene - Java
> Issue Type: Improvement
> Reporter: Ryan McKinley
> Fix For: 4.0
>
> Attachments: LUCENE-2649-FieldCacheWithBitSet.patch,
> LUCENE-2649-FieldCacheWithBitSet.patch,
> LUCENE-2649-FieldCacheWithBitSet.patch, LUCENE-2649-FieldCacheWithBitSet.patch
>
>
> The FieldCache returns an array representing the values for each doc.
> However there is no way to know if the doc actually has a value.
> This should be changed to return an object representing the values *and* a
> BitSet for all valid docs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
