[
https://issues.apache.org/jira/browse/LUCENE-5404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13889069#comment-13889069
]
Areek Zillur commented on LUCENE-5404:
--------------------------------------
Thanks for the feedback :)
I was thinking the "count" stuff should be common to all suggesters, hence put
it in super. I will change it so that the suggesters themselves take care of
it.
I will create an issue to let suggesters use CodecUtil.write/checkHeader.
Thanks for pointing that out.
Regarding .store/.load, I was thinking if we could use something more general
so that we can read/write directories (for AnalyzingInfixSuggester and co),
along with files (for other suggesters)? I think that will let all suggester
impl to respect the Lookup API. Any thoughts on this?
> Add support to get number of entries a Suggester Lookup was built with and
> minor refactorings
> ---------------------------------------------------------------------------------------------
>
> Key: LUCENE-5404
> URL: https://issues.apache.org/jira/browse/LUCENE-5404
> Project: Lucene - Core
> Issue Type: Improvement
> Components: core/search
> Reporter: Areek Zillur
> Fix For: 5.0, 4.7
>
> Attachments: LUCENE-5404.patch, LUCENE-5404.patch, LUCENE-5404.patch
>
>
> It would be nice to be able to tell the number of entries a suggester lookup
> was built with. This would let components using lookups to keep some stats
> regarding how many entries were used to build a lookup.
> Additionally, Dictionary could use InputIterator rather than the
> BytesRefIteratator, as most of the implmentations now use it.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
