[
https://issues.apache.org/jira/browse/LUCENE-5404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13891977#comment-13891977
]
Michael McCandless commented on LUCENE-5404:
--------------------------------------------
+1, patch looks great, thanks Areek.
{quote}
On a different note, I also see the different options that can be fed in the
lookup() for different suggesters, I was thinking an object (LookupOptions?)
can be passed instead (which will encapsulate all the params). I think this
will make the API 'cleaner' and allow suggester specific options to be passed
by just using the Lookup class, Thoughts? (I will probably just do this
separately)
{quote}
I think maybe each suggester should just have its own lookup method, taking its
additional params? Ie, I'm not sure how consistently each one will have
options that the others would want to use. E.g. AnalyzingInfixSuggester
accepts two additional booleans: allTermsRequired, doHighlight. But I don't
think other suggesters can support these options...
> Add support to get number of entries a Suggester Lookup was built with and
> minor refactorings
> ---------------------------------------------------------------------------------------------
>
> Key: LUCENE-5404
> URL: https://issues.apache.org/jira/browse/LUCENE-5404
> Project: Lucene - Core
> Issue Type: Improvement
> Components: core/search
> Reporter: Areek Zillur
> Fix For: 5.0, 4.7
>
> Attachments: LUCENE-5404.patch, LUCENE-5404.patch, LUCENE-5404.patch,
> LUCENE-5404.patch
>
>
> It would be nice to be able to tell the number of entries a suggester lookup
> was built with. This would let components using lookups to keep some stats
> regarding how many entries were used to build a lookup.
> Additionally, Dictionary could use InputIterator rather than the
> BytesRefIteratator, as most of the implmentations now use it.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
