[
https://issues.apache.org/jira/browse/LUCENE-5404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13889408#comment-13889408
]
Michael McCandless commented on LUCENE-5404:
--------------------------------------------
Thanks Areek.
{quote}
Regarding .store/.load, I was thinking if we could use something more general
so that we can read/write directories (for AnalyzingInfixSuggester and co),
along with files (for other suggesters)? I think that will let all suggester
impl to respect the Lookup API. Any thoughts on this?
{quote}
I'm not really sure what to do w/ the store/load APIs. It may be too much to
ask that all suggesters use a common API for it. E.g, it's sort of weird to 1)
create a new suggester class, and 2) call its load API; it's more natural to
create the suggester, passing in a Dir/File where it should load its state
from. Ie, you are either loading a previously built suggester, or you creating
a new one. Today the API allows you to load a previously built one and then
also .build() a new one over it, which is strange. I think LUCENE-4492 is
getting at this too ...
E.g., AnalyzingInfixSuggester cannot do this: it loads itself based on what you
passed to the ctor, so it's .load does nothing.
> Add support to get number of entries a Suggester Lookup was built with and
> minor refactorings
> ---------------------------------------------------------------------------------------------
>
> Key: LUCENE-5404
> URL: https://issues.apache.org/jira/browse/LUCENE-5404
> Project: Lucene - Core
> Issue Type: Improvement
> Components: core/search
> Reporter: Areek Zillur
> Fix For: 5.0, 4.7
>
> Attachments: LUCENE-5404.patch, LUCENE-5404.patch, LUCENE-5404.patch
>
>
> It would be nice to be able to tell the number of entries a suggester lookup
> was built with. This would let components using lookups to keep some stats
> regarding how many entries were used to build a lookup.
> Additionally, Dictionary could use InputIterator rather than the
> BytesRefIteratator, as most of the implmentations now use it.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
