[
https://issues.apache.org/jira/browse/LUCENE-5703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14018463#comment-14018463
]
Robert Muir commented on LUCENE-5703:
-------------------------------------
Ill start tackling the EMPTY issue. it shouldn't be controversial at all, but
the safety here is mandatory because this constant is used by SegmentMerger.
As far as the all-in-ram ones exposing the ability to corrupt the same stuff
thats merged, we can think of a number of compromises / solutions, but
something must be done:
* System.arraycopy
* big fat warnings on these that they are "unsafe" (they are not part of the
official index format, so maybe thats ok).
* they could keep ahold of their file descriptors and override merge() to
stream the data from the file.
> Don't allocate/copy bytes all the time in binary DV producers
> -------------------------------------------------------------
>
> Key: LUCENE-5703
> URL: https://issues.apache.org/jira/browse/LUCENE-5703
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Adrien Grand
> Assignee: Adrien Grand
> Fix For: 4.9, 5.0
>
> Attachments: LUCENE-5703.patch, LUCENE-5703.patch, LUCENE-5703.patch,
> LUCENE-5703.patch, LUCENE-5703.patch
>
>
> Our binary doc values producers keep on creating new {{byte[]}} arrays and
> copying bytes when a value is requested, which likely doesn't help
> performance. This has been done because of the way fieldcache consumers used
> the API, but we should try to fix it in 5.0.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
