[ https://issues.apache.org/jira/browse/LUCENE-5703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14018656#comment-14018656 ]
Adrien Grand commented on LUCENE-5703: -------------------------------------- {quote} * System.arraycopy * big fat warnings on these that they are "unsafe" (they are not part of the official index format, so maybe thats ok). * they could keep ahold of their file descriptors and override merge() to stream the data from the file. {quote} I'm hesitating between the 1st and 2nd idea. I'm not a fan of the 3rd idea as it would make merging a bit more complex although I really like how simple it is today. Since the default codec doesn't have the issue and since this issue already exists in other index formats (eg. the payload of DirectPostingsFormat), I think it would be fine to just have a warning? > Don't allocate/copy bytes all the time in binary DV producers > ------------------------------------------------------------- > > Key: LUCENE-5703 > URL: https://issues.apache.org/jira/browse/LUCENE-5703 > Project: Lucene - Core > Issue Type: Improvement > Reporter: Adrien Grand > Assignee: Adrien Grand > Fix For: 4.9, 5.0 > > Attachments: LUCENE-5703.patch, LUCENE-5703.patch, LUCENE-5703.patch, > LUCENE-5703.patch, LUCENE-5703.patch, LUCENE-5703.patch, LUCENE-5703.patch > > > Our binary doc values producers keep on creating new {{byte[]}} arrays and > copying bytes when a value is requested, which likely doesn't help > performance. This has been done because of the way fieldcache consumers used > the API, but we should try to fix it in 5.0. -- This message was sent by Atlassian JIRA (v6.2#6252) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org