[
https://issues.apache.org/jira/browse/SOLR-6260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14067935#comment-14067935
]
Yonik Seeley commented on SOLR-6260:
------------------------------------
bq. I don't know really what "direct" means here.
It's right in the class javadoc comment:
{code}
/**
* <code>DirectUpdateHandler2</code> implements an UpdateHandler where
documents are added
* directly to the main Lucene index as opposed to adding to a separate smaller
index.
{code}
In general, renames like this can cause more pain than the meager benefits they
provide.
This would break compatibility for users schemas who are trying to upgrade.
Regarding renaming public APIs in general:
https://issues.apache.org/jira/browse/SOLR-3830?focusedCommentId=13454299&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13454299
Along the lines of "collective knowledge", that includes a whole ton of mail
archives, blogs, books, etc, that refer to this class (or it's shortened name
DUH2... which actually works to type into the class finder in intellij).
> Rename DirectUpdateHandler2
> ---------------------------
>
> Key: SOLR-6260
> URL: https://issues.apache.org/jira/browse/SOLR-6260
> Project: Solr
> Issue Type: Improvement
> Affects Versions: 5.0
> Reporter: Tomás Fernández Löbbe
> Priority: Minor
> Attachments: SOLR-6260.patch, SOLR-6260.patch
>
>
> "DirectUpdateHandler" was removed, I think in Solr 4. DirectUpdateHandler2
> should be renamed, at least remove that "2". I don't know really what
> "direct" means here. Maybe it could be renamed to "DefaultUpdateHandler", or
> "UpdateHandlerDefaultImpl", or other good suggestions
--
This message was sent by Atlassian JIRA
(v6.2#6252)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
