[
https://issues.apache.org/jira/browse/SOLR-6260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14067981#comment-14067981
]
Tomás Fernández Löbbe commented on SOLR-6260:
---------------------------------------------
bq. It's right in the class javadoc comment:
I see, I missed that.
Sorry for my ignorance, but does this comment make sense now? Is it possible in
Solr to add documents to a different index (other than having a separate core)
or is this comment outdated?
I agree with Mark, cleaning ugly code should be encouraged, and a class called
“DirectUpdateHandler2” is an ugly name. I someone new to Solr sees this they
would ask “Why is it called like this? Why is this ‘2’? Is there another number
‘1’? does it accomplish the same?”, and responding “It’s for historic reasons”
is a bad response I think.
bq. Looking at this patch specifically, on it's own merits, it doesn't seem
worth it to me.
What does that mean? I can clean the patch if needed. As I said, I did mostly
a search and replace, maybe there is more to be done.
bq. As far as encouraging new users to make changes, I'd rather encourage them
to make more meaningful changes
I find this change as a step forward, that’s why I suggested it.
> Rename DirectUpdateHandler2
> ---------------------------
>
> Key: SOLR-6260
> URL: https://issues.apache.org/jira/browse/SOLR-6260
> Project: Solr
> Issue Type: Improvement
> Affects Versions: 5.0
> Reporter: Tomás Fernández Löbbe
> Priority: Minor
> Attachments: SOLR-6260.patch, SOLR-6260.patch
>
>
> "DirectUpdateHandler" was removed, I think in Solr 4. DirectUpdateHandler2
> should be renamed, at least remove that "2". I don't know really what
> "direct" means here. Maybe it could be renamed to "DefaultUpdateHandler", or
> "UpdateHandlerDefaultImpl", or other good suggestions
--
This message was sent by Atlassian JIRA
(v6.2#6252)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
