I'll fix the message to make it clear you are not running on WINDOWS but rather our WindowsFS.
I agree we should strive to have our tests be portable across OS's ... But unfortunately this test case is for a nasty corruption bug (LUCENE-5574) that can't happen on Windows... Mike McCandless http://blog.mikemccandless.com On Mon, Dec 1, 2014 at 7:14 PM, Robert Muir <[email protected]> wrote: > -1. > > our test framework doesnt need to support this. the problem here is > the test, its no good and doesnt work on windows. An assume is the > correct answer for a shitty test. > > On Mon, Dec 1, 2014 at 5:46 PM, Chris Hostetter > <[email protected]> wrote: >> >> : assumeFalse("this test can't run on Windows", Constants.WINDOWS); >> : >> : MockDirectoryWrapper dir = newMockDirectory(); >> : + if (TestUtil.isWindowsFS(dir)) { >> : + dir.close(); >> : + assumeFalse("this test can't run on Windows", true); >> : + } >> >> this specific assume msg seems like a bad idea. >> >> ie: a new dev, who doesn't know about the FS mocking behavior of >> the test cases, who tries to run lucene tests on a mac and sees a >> test skipped with the message "this test can't run on Windows" i'm going >> to be confused as hell. >> >> I also have to wonder: rather then just a straight assumeFalse, wouldn't >> it be better in this case to just upwrap the mock "windowsfs" and just >> explicitly use the "real" fs for this particular test? (in hte interest of >> maximizing test coverage) >> >> >> -Hoss >> http://www.lucidworks.com/ >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: [email protected] >> For additional commands, e-mail: [email protected] >> > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
