: I'll fix the message to make it clear you are not running on WINDOWS : but rather our WindowsFS.
thanks. : I agree we should strive to have our tests be portable across OS's ... : : But unfortunately this test case is for a nasty corruption bug : (LUCENE-5574) that can't happen on Windows... I don't really understand how that statment relates to either of my questions? Currently, if i a non-windows user runs all tests on their machine the framework will select "windowsfs" as a mock file system roughly 1/10th of the test runs (9/10 * 1/10). With your latest commit, this test -- knowing that it is useless on windows *OR* the mock windowsfs -- jumps through hoops to ask "TestUtil.isWindowsFS(dir)" ? ... and if the answer is "true", it does nothing (via: assumeFalse) my question: rather then assumeFalse() ~1/10 of the time (even when the underlying OS/FS is *NOT* windows) why not unwrap that (mock) windowsfs and still run the test using the real file system? Wouldn't that be trivial to do? It doesn't seem any more complicated then what you had to add to implement "isWindowsFS" ... can't we just change those "isWindowsFS" boolean methods to something that returns the actual WindowsFS instance and calls getDelegate() on it? -Hoss http://www.lucidworks.com/ --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
