On Tue, Dec 2, 2014 at 12:01 PM, Chris Hostetter <[email protected]> wrote:
> my question: rather then assumeFalse() ~1/10 of the time (even when the > underlying OS/FS is *NOT* windows) why not unwrap that (mock) windowsfs > and still run the test using the real file system? > > Wouldn't that be trivial to do? It doesn't seem any more complicated then > what you had to add to implement "isWindowsFS" ... can't we just change > those "isWindowsFS" boolean methods to something that returns the actual > WindowsFS instance and calls getDelegate() on it? > Personally i am against this, we shouldn't make this method public! The test has a problem in that it does not work on windows, but the test framework doesnt need to become flaky to cater to this kind of stuff. --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
