[ 
https://issues.apache.org/jira/browse/LUCENE-6069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14316028#comment-14316028
 ] 

Uwe Schindler commented on LUCENE-6069:
---------------------------------------

I know. But instead of removing functionality can we just stick with my patch - 
a 2 line change removing the ManagamentFactory dependency? If you run on a 
mobile phone with compact profile it just assumes "8" - otherwise it works as 
before.

Removing that is just another thing, but we already rely on more or less exact 
calculations for Accountable. This makes a lot of difference for Accountable 
reports (we dont calculate dynamically by refelction, but we sum up constants 
everywhere). So we should do our best to get the "constants" as exact as 
possible.

In fact your patch was not removing completely, the Enum constant was still 
kept alive and so on. So lets keep what we have, just make it optional.

> compile with compact profiles
> -----------------------------
>
>                 Key: LUCENE-6069
>                 URL: https://issues.apache.org/jira/browse/LUCENE-6069
>             Project: Lucene - Core
>          Issue Type: Task
>          Components: general/build
>    Affects Versions: Trunk
>            Reporter: Robert Muir
>            Assignee: Robert Muir
>             Fix For: Trunk
>
>         Attachments: LUCENE-6069.patch, LUCENE-6069.patch, LUCENE-6069.patch
>
>
> If we clean up the 'alignment' calculator in RamUsageEstimator, we can 
> compile core with compact1, and the rest of lucene (except tests) with 
> compact2.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to