[ 
https://issues.apache.org/jira/browse/LUCENE-6069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14316043#comment-14316043
 ] 

Uwe Schindler commented on LUCENE-6069:
---------------------------------------

bq. Sorry man, i don't mean to be rude, but all this is really crap.

Why? I maintained the code very carefully with Dawid. Please don't call my code 
crap, this hurts, really! I agree, it is hard to test something that may not be 
available, but I will look into it to make a test that has a hard check for 
this.

Sorry for beeing to late on this issue, I fixed it in 5 minutes, I am very 
sorry. But don't let us remove functionality that works and helps for our 
accounting fetaures. In fact this code does not even use any unsafe APIs this 
is just a perfectly legal way to get this constant. So I am -1 to remove it, 
sorry.

> compile with compact profiles
> -----------------------------
>
>                 Key: LUCENE-6069
>                 URL: https://issues.apache.org/jira/browse/LUCENE-6069
>             Project: Lucene - Core
>          Issue Type: Task
>          Components: general/build
>    Affects Versions: Trunk
>            Reporter: Robert Muir
>            Assignee: Robert Muir
>             Fix For: Trunk
>
>         Attachments: LUCENE-6069.patch, LUCENE-6069.patch, LUCENE-6069.patch
>
>
> If we clean up the 'alignment' calculator in RamUsageEstimator, we can 
> compile core with compact1, and the rest of lucene (except tests) with 
> compact2.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to