[ 
https://issues.apache.org/jira/browse/LUCENE-6069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14316048#comment-14316048
 ] 

Robert Muir commented on LUCENE-6069:
-------------------------------------

{quote}
Sorry for beeing to late on this issue, I fixed it in 5 minutes, I am very sorry
{quote}

Again, you didnt fix it, its not complete. The fake "test" needs to also be 
fixed/removed, like my patch.

{quote}
In fact this code does not even use any unsafe APIs this is just a perfectly 
legal way to get this constant. So I am -1 to remove it, sorry.
{quote}

So you will prevent lucene from being used on more platforms, when the code in 
question *DOES NOTHING*, just becausse you think your code, that *DOES NOTHING* 
is awesome?

> compile with compact profiles
> -----------------------------
>
>                 Key: LUCENE-6069
>                 URL: https://issues.apache.org/jira/browse/LUCENE-6069
>             Project: Lucene - Core
>          Issue Type: Task
>          Components: general/build
>    Affects Versions: Trunk
>            Reporter: Robert Muir
>            Assignee: Robert Muir
>             Fix For: Trunk
>
>         Attachments: LUCENE-6069.patch, LUCENE-6069.patch, LUCENE-6069.patch
>
>
> If we clean up the 'alignment' calculator in RamUsageEstimator, we can 
> compile core with compact1, and the rest of lucene (except tests) with 
> compact2.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to