[
https://issues.apache.org/jira/browse/SOLR-7110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14492507#comment-14492507
]
Shalin Shekhar Mangar commented on SOLR-7110:
---------------------------------------------
I see that in JavaBinCodec.readExternString you have changed:
{code}
- String s = (String) readVal(fis);
+ tagByte = fis.readByte();
+ String s = readStr(fis, stringCache);
{code}
But I cannot find the corresponding change to writeExternString. How does this
work?
> Optimize JavaBinCodec to minimize string Object creation
> --------------------------------------------------------
>
> Key: SOLR-7110
> URL: https://issues.apache.org/jira/browse/SOLR-7110
> Project: Solr
> Issue Type: Improvement
> Reporter: Noble Paul
> Assignee: Noble Paul
> Priority: Minor
> Fix For: Trunk, 5.2
>
> Attachments: SOLR-7110.patch, SOLR-7110.patch, SOLR-7110.patch
>
>
> In JavabinCodec we already optimize on strings creation , if they are
> repeated in the same payload. if we use a cache it is possible to avoid
> string creation across objects as well.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
