[ 
https://issues.apache.org/jira/browse/SOLR-7110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14492535#comment-14492535
 ] 

Yonik Seeley commented on SOLR-7110:
------------------------------------

OK I did some performance testing (since I don't see the reason to commit 
something that won't be used).  I decoded random documents with the same set of 
fields (meaning there will be 100% hit rate on the string cache - a best case 
scenario for it).

Single threaded: using a string cache impacted decoding performance anywhere 
from 2.5-7 percent... median looked to be around 3.5% lower performance.
2 core processor with 4 decoding threads: I saw decreases in performance 
ranging from 18% to 30%
4 core processor with 4 decoding threads: I saw decreases in performance 
averaging about 23%

So in general, it seems like trying to cache relatively small objects with a 
relatively expensive cache is a lose.

> Optimize JavaBinCodec to minimize string Object creation
> --------------------------------------------------------
>
>                 Key: SOLR-7110
>                 URL: https://issues.apache.org/jira/browse/SOLR-7110
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Noble Paul
>            Assignee: Noble Paul
>            Priority: Minor
>             Fix For: Trunk, 5.2
>
>         Attachments: SOLR-7110.patch, SOLR-7110.patch, SOLR-7110.patch
>
>
> In JavabinCodec we already optimize on strings creation , if they are 
> repeated in the same payload. if we use a cache it is possible to avoid 
> string creation across objects as well.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to