[ 
https://issues.apache.org/jira/browse/SOLR-7110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14492578#comment-14492578
 ] 

Yonik Seeley commented on SOLR-7110:
------------------------------------

bq. if it is slower by a few of nanoseconds

I don't run things for a new nanoseconds in benchmarks.  In this case, I ran 
enough decode iterations to run for at least 30 seconds per run, more than 
enough time for the cache to have a positive effect on garbage collection times 
as well. 

I am -1 on enabling/using this cache.

> Optimize JavaBinCodec to minimize string Object creation
> --------------------------------------------------------
>
>                 Key: SOLR-7110
>                 URL: https://issues.apache.org/jira/browse/SOLR-7110
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Noble Paul
>            Assignee: Noble Paul
>            Priority: Minor
>             Fix For: Trunk, 5.2
>
>         Attachments: SOLR-7110.patch, SOLR-7110.patch, SOLR-7110.patch
>
>
> In JavabinCodec we already optimize on strings creation , if they are 
> repeated in the same payload. if we use a cache it is possible to avoid 
> string creation across objects as well.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to