[ 
https://issues.apache.org/jira/browse/SOLR-7110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14498028#comment-14498028
 ] 

Yonik Seeley commented on SOLR-7110:
------------------------------------

bq. So, we should do some simple warm up before running all tests

No... it's much more difficult to account for all the mud in the water by 
running different options in the same JVM run.  It's simplest to just not put 
mud in the water in the first place.  One needs to run each variant multiple 
times in different JVM runs as well since hotspot can sometimes optimize one 
run pretty well by luck.

Oh, and due to CPU speed changes due to thermal throttling, it's probably best 
to alternate  variants as well.  I did something like the following:
for i in 1 2 3 4 5 6 7 8 9 10; do test_variant1; test variant 2; done

bq. Anyway, Wha twere the numbers you got?
I gave the aggregate results... I don't have time to re-run them all now.


> Optimize JavaBinCodec to minimize string Object creation
> --------------------------------------------------------
>
>                 Key: SOLR-7110
>                 URL: https://issues.apache.org/jira/browse/SOLR-7110
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Noble Paul
>            Assignee: Noble Paul
>            Priority: Minor
>             Fix For: Trunk, 5.2
>
>         Attachments: JavabinPerf.patch, JavabinPerf.patch, SOLR-7110.patch, 
> SOLR-7110.patch, SOLR-7110.patch
>
>
> In JavabinCodec we already optimize on strings creation , if they are 
> repeated in the same payload. if we use a cache it is possible to avoid 
> string creation across objects as well.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to