[ 
https://issues.apache.org/jira/browse/SOLR-7110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14498052#comment-14498052
 ] 

Yonik Seeley commented on SOLR-7110:
------------------------------------

bq. I don't think you approach of fresh JVM is ideal because in reality we have 
a JVM that is warmed . 

a) "warming" the JVM with a different option of what you are testing is *bad*, 
it will lead to hotspot specialization and then de-specialization.
b) run the test for longer... most of the time will be 
c) if you really want to warm the JVM, do the *same* variant twice and just 
time the second one

bq. It is well known that [...]

If you insist on inferring performance rather than directly measuring it w/o 
throwing unnecessary mud in the water, then I'm just going to start ignoring 
your results and reiterate my -1

> Optimize JavaBinCodec to minimize string Object creation
> --------------------------------------------------------
>
>                 Key: SOLR-7110
>                 URL: https://issues.apache.org/jira/browse/SOLR-7110
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Noble Paul
>            Assignee: Noble Paul
>            Priority: Minor
>             Fix For: Trunk, 5.2
>
>         Attachments: JavabinPerf.patch, JavabinPerf.patch, SOLR-7110.patch, 
> SOLR-7110.patch, SOLR-7110.patch
>
>
> In JavabinCodec we already optimize on strings creation , if they are 
> repeated in the same payload. if we use a cache it is possible to avoid 
> string creation across objects as well.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to